Do

Error in firefox bookmarks parser

Bug #276041 reported by Zombywuf
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Do
Invalid
Undecided
Unassigned
Do Plugins
Fix Released
High
Unassigned

Bug Description

The JSON parser in the Firefox plugin fails to get all bookmarks in some cases. The problem is caused by iUri finding the next bookmarks uri parameter and parsing continuing from there when an entry without a uri is found.

Adding this after the if in LoadBookmarkItems fixes the problem.

else {
  iUri = iChildren;
}

Revision history for this message
Lesley Harrington (laharrin) wrote :

I may be experiencing a specific instance of this bug:

I have Gmail bookmarked (https://mail.google.com/mail) but it is not called up by Do, despite being in both my json and bookmarks.html files.

Could more information please be provided on how to implement the workaround above; where do I find LoadBookmarkItems?

thanks.

Revision history for this message
Zombywuf (t-launchpad-zombywuf-org) wrote :

It's in do-plugins/Firefox/src/BookmarkItemSource.cs You'll need to check out the do-plugins and patch it manually until a dev pays attention to this bug.

David Siegel (djsiegel-deactivatedaccount)
Changed in do:
status: New → Invalid
Changed in do-plugins:
assignee: nobody → djsiegel
importance: Undecided → High
status: New → Confirmed
David Siegel (djsiegel-deactivatedaccount)
Changed in do-plugins:
status: Confirmed → In Progress
Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

Zombywuf, can you confirm that is bug is fixed in version 2.2 or later of the Firefox plugin. I am sorry it took so long to get around to your bug.

Revision history for this message
Zombywuf (t-launchpad-zombywuf-org) wrote :

I'm not able to build the latest version of gnome-do without installing a newer version of mono (I think). Ubuntu Hardy only supports 1.2.6 currently. What version am I going to need?

Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote : Re: [Bug 276041] Re: Error in firefox bookmarks parser

Yes, you need the version in Intrepid (1.9) or later. Now's a good
time to upgrade! :)

Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

Or, you can copy the updated function into your source for the old
version and confirm the fix.

Revision history for this message
Zombywuf (t-launchpad-zombywuf-org) wrote :

OK, upgraded to Intrepid, fglrx is broken but the firefox plugin works.

David Siegel (djsiegel-deactivatedaccount)
Changed in do-plugins:
status: In Progress → Fix Committed
David Siegel (djsiegel-deactivatedaccount)
Changed in do-plugins:
status: Fix Committed → Fix Released
Revision history for this message
oshmoz (oshmoz) wrote :

Hello,
  I'm having the same problem with Gmail, The firefox plugin does not recognise this specific site. I'm using Gnome-Do 0.8.1.3 from ubuntu (9.04) repositories with firefox plugin 2.2. I can access all my bookmarks except gmail. I verified that Gmail bookmark does exist in my bookmarks.html.

Any ideas?
Osh.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.