If automatic checks is off, check for updates is triggered and then remind me later is checked, the dialog keeps coming back
Bug #230347 reported by
Scott Gruby
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Sparkle |
Fix Released
|
High
|
Unassigned |
Bug Description
1. In the test app, uncheck "Automatically check for updates"
2. Quit test app
3. Launch test app
4. Choose Choose for updates from the Sparkle Test App menu
5. Click Remind Me Later
The update alert comes back.
(bzr revision 128)
Related branches
Changed in sparkle: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The following appears to fix the issue:
In SUUpdater.m,
- (void)observeVa lueForKeyPath: (NSString *)keyPath ofObject:(id)object change: (NSDictionary *)change context:(void *)context
Change
[NSTimer scheduledTimerW ithTimeInterval :checkInterval target:self selector: @selector( checkForUpdates InBackground) userInfo:nil repeats:NO];
to
if ([self automaticallyUp dates]) ithTimeInterval :checkInterval target:self selector: @selector( checkForUpdates InBackground) userInfo:nil repeats:NO];
{
[NSTimer scheduledTimerW
}