If automatic checks is off, check for updates is triggered and then remind me later is checked, the dialog keeps coming back

Bug #230347 reported by Scott Gruby
2
Affects Status Importance Assigned to Milestone
Sparkle
Fix Released
High
Unassigned

Bug Description

1. In the test app, uncheck "Automatically check for updates"
2. Quit test app
3. Launch test app
4. Choose Choose for updates from the Sparkle Test App menu
5. Click Remind Me Later

The update alert comes back.

(bzr revision 128)

Related branches

Revision history for this message
Scott Gruby (b-launchpad-net-gruby-com) wrote :

The following appears to fix the issue:

In SUUpdater.m,

- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context

Change

  [NSTimer scheduledTimerWithTimeInterval:checkInterval target:self selector:@selector(checkForUpdatesInBackground) userInfo:nil repeats:NO];

to

 if ([self automaticallyUpdates])
 {
  [NSTimer scheduledTimerWithTimeInterval:checkInterval target:self selector:@selector(checkForUpdatesInBackground) userInfo:nil repeats:NO];
 }

Revision history for this message
Andy Matuschak (andymatuschak) wrote :

Committed. Thanks, Scott.

Changed in sparkle:
importance: Undecided → High
milestone: none → 1.5
status: New → Fix Committed
Changed in sparkle:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.