scheduled reboot reboots immediately if dbus or logind is not available

This is addressed in Debian and has been downstreamed to Hirsute.
The following debdiffs are to SRU it for B,G,F.

Debdiff for Bionic.

Debdiff for Groovy.

Debdiff for Focal.

Debdiff for Focal.

@joalif, one thing I noticed, that isn't important for this SRU, is that the !ENABLE_LOGIND case still has a log message indicating shutdown will happen immediately, i.e.:

int logind_schedule_shutdown(void) {

#if ENABLE_LOGIND
...stuff...
#else
        return log_error_errno(SYNTHETIC_ERRNO(ENOSYS),
                               "Cannot schedule shutdown without logind support, proceeding with immediate shutdown.");
#endif
}

however, since the caller has been changed to return error instead of immediate reboot, maybe that message should be changed as well. I'd actually suggest that both messages in this function, that state what will happen next but rely on the caller to actually do what the log states, are in the wrong place, and the *calling* function should log an appropriate message about what it's doing next instead of this function.

Doesn't matter for this though since we do define ENABLE_LOGIND for our builds, just a suggestion if you want to send a patch to debian :)

minor comment, for systemd (and really all packages) I like to name the patches with the lp bug number, so i changed your patch name to add the lp1911187- prefix.

also another minor comment, as we'd discussed before I made a slight change to the comment in the patch for clarification:

         if (arg_when > 0)
                 return logind_schedule_shutdown();

- /* no delay, or logind is not at all available */
+ /* no delay */
         if (geteuid() != 0) {
                 if (arg_dry_run || arg_force > 0) {
                         (void) must_be_root();

Hello Ioanna, or anyone else affected,

Accepted systemd into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/246.6-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Ioanna, or anyone else affected,

Accepted systemd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/245.4-4ubuntu3.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Ioanna, or anyone else affected,

Accepted systemd into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/237-3ubuntu10.45 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

All autopkgtests for the newly accepted systemd (237-3ubuntu10.45) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

corosync/2.4.3-0ubuntu1.1 (armhf)
lxc/3.0.3-0ubuntu1~18.04.1 (amd64)
openssh/1:7.6p1-4ubuntu0.3 (amd64, ppc64el, arm64, i386, armhf, s390x)
linux-hwe-5.0/5.0.0-65.71 (i386)
linux-hwe-5.4/5.4.0-67.75~18.04.1 (i386)
gvfs/1.36.1-0ubuntu1.3.3 (amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#systemd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted systemd (245.4-4ubuntu3.5) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

prometheus-apache-exporter/0.7.0+ds-1 (arm64)
udisks2/2.8.4-1ubuntu1 (amd64, ppc64el)
munin/2.0.56-1ubuntu1 (arm64)
docker.io/19.03.8-0ubuntu1.20.04.2 (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#systemd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted systemd (246.6-1ubuntu1.2) for groovy have finished running.
The following regressions have been reported in tests triggered by the package:

snapd/2.48.3+20.10 (amd64)
nut/2.7.4-12ubuntu1 (ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/groovy/update_excuses.html#systemd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

# VERIFICATION BIONIC

Installed systemd from -proposed :
# dpkg -l | grep systemd
ii libnss-resolve:amd64 237-3ubuntu10.45 amd64 nss module to resolve names via systemd-resolved
ii libnss-systemd:amd64 237-3ubuntu10.45 amd64 nss module providing dynamic user and group name resolution
ii libpam-systemd:amd64 237-3ubuntu10.45 amd64 system and service manager - PAM module
ii libsystemd-dev:amd64 237-3ubuntu10.45 amd64 systemd utility library - development files
ii libsystemd0:amd64 237-3ubuntu10.45 amd64 systemd utility library
ii networkd-dispatcher 1.7-0ubuntu3.3 all Dispatcher service for systemd-networkd connection status changes
ii python3-systemd 234-1build1 amd64 Python 3 bindings for systemd
ii systemd 237-3ubuntu10.45 amd64 system and service manager
ii systemd-container 237-3ubuntu10.45 amd64 systemd container/nspawn tools
ii systemd-journal-remote 237-3ubuntu10.45 amd64 tools for sending and receiving remote journal logs
ii systemd-sysv 237-3ubuntu10.45 amd64 system and service manager - SysV links
ii systemd-tests 237-3ubuntu10.45 amd64 tests for systemd

Following test plan from description

# systemctl stop dbus.service
# systemctl stop dbus.socket
# shutdown +1 -r "REBOOT!"
Failed to set wall message, ignoring: Refusing activation, D-Bus is shutting down.
Failed to call ScheduleShutdown in logind, no action will be taken: Refusing activation, D-Bus is shutting down.

Machine does not reboot as expected.

# VERIFICATION FOCAL

Installed systemd from -proposed :
# dpkg -l | grep systemd
ii libnss-resolve:amd64 245.4-4ubuntu3.5 amd64 nss module to resolve names via systemd-resolved
ii libnss-systemd:amd64 245.4-4ubuntu3.5 amd64 nss module providing dynamic user and group name resolution
ii libpam-systemd:amd64 245.4-4ubuntu3.5 amd64 system and service manager - PAM module
ii libsystemd-dev:amd64 245.4-4ubuntu3.5 amd64 systemd utility library - development files
ii libsystemd0:amd64 245.4-4ubuntu3.5 amd64 systemd utility library
ii networkd-dispatcher 2.0.1-1 all Dispatcher service for systemd-networkd connection status changes
ii systemd 245.4-4ubuntu3.5 amd64 system and service manager
ii systemd-container 245.4-4ubuntu3.5 amd64 systemd container/nspawn tools
ii systemd-journal-remote 245.4-4ubuntu3.5 amd64 tools for sending and receiving remote journal logs
ii systemd-sysv 245.4-4ubuntu3.5 amd64 system and service manager - SysV links
ii systemd-tests 245.4-4ubuntu3.5 amd64 tests for systemd
ii systemd-timesyncd 245.4-4ubuntu3.5 amd64 minimalistic service to synchronize local time with NTP servers

Following test plan from description

# systemctl stop dbus.service
# systemctl stop dbus.socket
# shutdown +1 -r "REBOOT!"
Failed to set wall message, ignoring: Connection timed out
Failed to call ScheduleShutdown in logind, no action will be taken: Connection timed out

Machine does not reboot as expected.

# VERIFICATION GROOVY

Installed systemd from -proposed :
# dpkg -l | grep systemd
ii libnss-resolve:amd64 246.6-1ubuntu1.2 amd64 nss module to resolve names via systemd-resolved
ii libnss-systemd:amd64 246.6-1ubuntu1.2 amd64 nss module providing dynamic user and group name resolution
ii libpam-systemd:amd64 246.6-1ubuntu1.2 amd64 system and service manager - PAM module
ii libsystemd-dev:amd64 246.6-1ubuntu1.2 amd64 systemd utility library - development files
ii libsystemd0:amd64 246.6-1ubuntu1.2 amd64 systemd utility library
ii systemd 246.6-1ubuntu1.2 amd64 system and service manager
ii systemd-container 246.6-1ubuntu1.2 amd64 systemd container/nspawn tools
ii systemd-journal-remote 246.6-1ubuntu1.2 amd64 tools for sending and receiving remote journal logs
ii systemd-sysv 246.6-1ubuntu1.2 amd64 system and service manager - SysV links
ii systemd-tests 246.6-1ubuntu1.2 amd64 tests for systemd
ii systemd-timesyncd 246.6-1ubuntu1.2 amd64 minimalistic service to synchronize local time with NTP servers

Following test plan from description

# systemctl stop dbus.service
# systemctl stop dbus.socket
# shutdown +1 -r "REBOOT!"
Failed to set wall message, ignoring: Connection timed out
Failed to call ScheduleShutdown in logind, no action will be taken: Failed to activate service 'org.freedesktop.login1': timed out (service_start_timeout=25000ms)

Machine does not reboot as expected.

Further verification that shows the non-zero return value of shutdown command,
when it fails to schedule a reboot and takes no action.

For Bionic :
# systemctl stop dbus.service
# systemctl stop dbus.socket
# shutdown +1 -r "REBOOT!"
Failed to set wall message, ignoring: Refusing activation, D-Bus is shutting down.
Failed to call ScheduleShutdown in logind, no action will be taken: Refusing activation, D-Bus is shutting down.
root@bionic:~# echo $?
1

For Focal :
# systemctl stop dbus.service
# systemctl stop dbus.socket
# shutdown +1 -r "REBOOT!"
root@focal:/home/jo# shutdown +1 -r "REBOOT!"
Failed to set wall message, ignoring: Failed to activate service 'org.freedesktop.login1': timed out (service_start_timeout=25000ms)
Failed to call ScheduleShutdown in logind, no action will be taken: Connection timed out
root@focal:/home/jo# echo $?
1

For Groovy :
# systemctl stop dbus.service
# systemctl stop dbus.socket
# shutdown +1 -r "REBOOT!"
Failed to set wall message, ignoring: Failed to activate service 'org.freedesktop.login1': timed out (service_start_timeout=25000ms)
Failed to call ScheduleShutdown in logind, no action will be taken: Failed to activate service 'org.freedesktop.login1': timed out (service_start_timeout=25000ms)
root@groovy:/home/jo# echo $?
1

The verification of the Stable Release Update for systemd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package systemd - 246.6-1ubuntu1.2

---------------
systemd (246.6-1ubuntu1.2) groovy; urgency=medium

  [ Ioanna Alifieraki ]
  * d/p/lp1911187-systemctl-do-not-shutdown-immediately-on-scheduled-shutdo.patch:
    Do not shutdown immediately when scheduled shutdown fails (LP: #1911187)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=bbca658178d27e0ffaf759ba3115878d26c917a6

  [ Dan Streetman ]
  * d/p/debian/patches/lp1880258-log-nxdomain-as-debug.patch:
    Change NXDOMAIN 'errors' to log level debug (LP: #1880258)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=b8e864eb907469616d688eab39b20491693d7c3a
  * d/p/lp1913763-udev-rules-add-rule-to-create-dev-ptp_hyperv.patch:
    Create symlink for hyperv-provided ptp device (LP: #1913763)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=83c7476c80e4139ee7c1ec18a549c30d37d3b4b2

 -- Ioanna Alifieraki <email address hidden> Tue, 23 Feb 2021 02:31:55 +0200

This bug was fixed in the package systemd - 245.4-4ubuntu3.5

---------------
systemd (245.4-4ubuntu3.5) focal; urgency=medium

  [ Ioanna Alifieraki ]
  * d/p/lp1911187-systemctl-do-not-shutdown-immediately-on-scheduled-shutdo.patch:
    Do not shutdown immediately when scheduled shutdown fails (LP: #1911187)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=3899c9d5c171e84fc503c6ab46aea7cc9def7235

  [ Dimitri John Ledkov ]
  * d/p/lp1878969-meson-initialize-time-epoch-to-reproducible-builds-compat.patch:
    meson: initialize time-epoch to reproducible builds compatible value
    (LP: #1878969)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=84212797d21ed08031e1d71fe5e118bdd9873c0f

  [ Dan Streetman ]
  * d/p/lp1913189-test-accept-that-char-device-0-0-can-now-be-created-.patch:
    - Fix failing test case under 5.8 kernel (LP: #1913189)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=782a382017ce188dbf9a40adabd265943d7db119
  * d/p/lp1913423-hashmap-make-sure-to-initialize-shared-hash-key-atom.patch:
    Thread-safe init of hashmap shared key (LP: #1913423)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=fc8dde7c4b1944d1583866f61c2314174b4dd06a
  * d/p/lp1902236-nss-systemd-don-t-synthesize-root-nobody-when-iterat.patch:
    Don't synthesize root/nobody when iterating (LP: #1902236)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=4d20e415ecd5b0fd032b4cf45bd9fd344cc434ac
  * d/p/debian/patches/lp1880258-log-nxdomain-as-debug.patch:
    Change NXDOMAIN 'errors' to log level debug (LP: #1880258)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=80163a2097aa876fe73b6071495ae4ad8749d04e
  * d/p/lp1913763-udev-rules-add-rule-to-create-dev-ptp_hyperv.patch:
    Create symlink for hyperv-provided ptp device (LP: #1913763)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=b02053da2ff3fee6221bd8310488af0f52b140f1

 -- Ioanna Alifieraki <email address hidden> Tue, 23 Feb 2021 00:18:57 +0000

This bug was fixed in the package systemd - 237-3ubuntu10.45

---------------
systemd (237-3ubuntu10.45) bionic; urgency=medium

  [ Ioanna Alifieraki ]
  * d/p/lp1911187-systemctl-do-not-shutdown-immediately-on-scheduled-shutdo.patch:
    Do not shutdown immediately when scheduled shutdown fails (LP: #1911187)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=257135a59455f4e4063e78cdd3f5cfeca2597b5b

  [ Dimitri John Ledkov ]
  * d/p/lp1878969-meson-initialize-time-epoch-to-reproducible-builds-compat.patch:
    meson: initialize time-epoch to reproducible builds compatible value
    (LP: #1878969)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=6f5a0c94ff4a486ee0b72af926672b24d16ff5a8

  [ Dan Streetman ]
  * d/p/lp1913189-test-accept-that-char-device-0-0-can-now-be-created-.patch:
    - Fix failing test case under 5.8 kernel (LP: #1913189)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=15143ec6cd584a18866390a042348a543e5aa22d
  * d/p/lp1913423-hashmap-make-sure-to-initialize-shared-hash-key-atom.patch:
    Thread-safe init of hashmap shared key (LP: #1913423)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=95c189adb9c3e22576b26b084c7edf001cbc8307
  * d/p/lp1890448-hwdb-Add-EliteBook-to-use-micmute-hotkey.patch:
    Add EliteBook to use micmute hotkey (LP: #1890448)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=19b48bdac5129aa772fbcd2dbf8d1bb5c30c1510
  * d/p/debian/patches/lp1902553-test-disable-QEMU-based-testing-for-TEST-16-EXTEND-T.patch:
    Disable TEST-03 run under qemu (LP: #1902553)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=4e37d20ec379d169cfd53088d0c3b4d7bb65d25b
  * d/p/debian/patches/lp1883447-seccomp-add-all-time64-syscalls.patch:
    Add *time64 syscalls (LP: #1883447)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=a459492c67c5c5855b03daca4b44141705495376
  * d/p/lp1685754-pid1-by-default-make-user-units-inherit-their-umask-.patch:
    Inherit umask for --user processes (LP: #1685754)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=00df8d0e76975594adb765182c587ef495262fe1
  * d/p/debian/patches/lp1880258-log-nxdomain-as-debug.patch:
    Change NXDOMAIN 'errors' to log level debug (LP: #1880258)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=9684abed02669bfcf696763b887518cf54cd3f69
  * d/p/lp1913763-udev-rules-add-rule-to-create-dev-ptp_hyperv.patch:
    Create symlink for hyperv-provided ptp device (LP: #1913763)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=ff2a9ed2ece6bbd86a3d57f42b26cb1a6ca2845a

 -- Ioanna Alifieraki <email address hidden> Tue, 23 Feb 2021 03:45:01 +0200