Ubuntu
linux package

ubuntu_zfs_xfs_generic / ubuntu_xftests_* failed to build on X-4.4

Bug #1882167 reported by Po-Hsu Lin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-kernel-tests
Fix Released
Undecided
Po-Hsu Lin
linux (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

The test compilation will fail with:
      cc: error: unrecognized command line option '-Wimplicit-fallthrough'

This build issue does not exist with 4.4.0-180 + gcc 5.4.0-6ubuntu1~16.04.12

Please find attachment for the full build log.

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: linux-image-4.4.0-181-generic 4.4.0-181.211
ProcVersionSignature: Ubuntu 4.4.0-181.211-generic 4.4.223
Uname: Linux 4.4.0-181-generic s390x
NonfreeKernelModules: zfs zunicode zcommon znvpair zavl
AlsaDevices: Error: command ['ls', '-l', '/dev/snd/'] failed with exit code 2: ls: cannot access '/dev/snd/': No such file or directory
AplayDevices: Error: [Errno 2] No such file or directory: 'aplay'
ApportVersion: 2.20.1-0ubuntu2.23
Architecture: s390x
ArecordDevices: Error: [Errno 2] No such file or directory: 'arecord'
CRDA: Error: command ['iw', 'reg', 'get'] failed with exit code 1: nl80211 not found.
CurrentDmesg:

Date: Thu Jun 4 22:56:00 2020
HibernationDevice: RESUME=/dev/mapper/mpatha1
IwConfig: Error: [Errno 2] No such file or directory: 'iwconfig'
Lspci:

Lsusb: Error: command ['lsusb'] failed with exit code 1:
PciMultimedia:

ProcFB: Error: [Errno 2] No such file or directory: '/proc/fb'
ProcKernelCmdLine: root=/dev/mapper/kernel01_vg-kernel01_lv crashkernel=196M BOOT_IMAGE=0
RelatedPackageVersions:
 linux-restricted-modules-4.4.0-181-generic N/A
 linux-backports-modules-4.4.0-181-generic N/A
 linux-firmware 1.157.23
RfKill: Error: [Errno 2] No such file or directory: 'rfkill'
SourcePackage: linux
UpgradeStatus: No upgrade log present (probably fresh install)

See original description
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

This option appears in the "fio" repo:
ubuntu@kernel01:~/autotest/client/tmp/ubuntu_zfs_xfs_generic/src/xfstests-bld$ grep -r "Wimplicit-fallthrough" *
fio/configure:# check if gcc has -Wimplicit-fallthrough
fio/configure:if compile_prog "-Wimplicit-fallthrough" "" "-Wimplicit-fallthrough"; then
fio/configure:print_config "-Wimplicit-fallthrough" "$fallthrough"
fio/configure: CFLAGS="$CFLAGS -Wimplicit-fallthrough"

$ gcc --version
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609

description: updated
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1882167

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Revision history for this message
Po-Hsu Lin (cypressyew) wrote : Re: ubuntu_zfs_xfs_generic failed to build on X-4.4

Boot back to 4.4.0-180 on the same instance, it's still having this issue.

And it looks like we're using the same test suite for 4.4.0-180 and 4.4.0-181

From the test history with 4.4.0-180:
 Running 'git clone https://github.com/tytso/xfstests-bld'
 Cloning into 'xfstests-bld'...
 Using head commit for xfstests-blda4df7d7b31125901cb1fe9b092f495b6aa950448
 Running 'git reset --hard a4df7d7b31125901cb1fe9b092f495b6aa950448'
 HEAD is now at a4df7d7 Update the default version of quota and xfsprogs
 Running './get-all'
 Cloning into 'fio'...
 Checking out fio fio-3.15 (previously was fio-3.19-74-gb09c96c)
 Cloning into 'quota'...
 Checking out quota 6e631074330a (previously was fdd774b)
 Cloning into 'xfsprogs-dev'...
 Checking out xfsprogs-dev v5.2.0 (previously was v5.6.0)
 Cloning into 'xfstests-dev'...
 Cloning into 'fsverity'...
 Cloning into 'blktests'...
 Using xfs from known stable commit point 82eda8820ddd68dab0bc35199a53a08f58b1d26c
 Running 'git reset --hard 82eda8820ddd68dab0bc35199a53a08f58b1d26c'

From the test history with 4.4.0-181:
 Running 'git clone https://github.com/tytso/xfstests-bld'
 Cloning into 'xfstests-bld'...
 Using head commit for xfstests-blda4df7d7b31125901cb1fe9b092f495b6aa950448
 Running 'git reset --hard a4df7d7b31125901cb1fe9b092f495b6aa950448'
 HEAD is now at a4df7d7 Update the default version of quota and xfsprogs
 Fetching all repos..
 Running './get-all'
 Cloning into 'fio'...
 Checking out fio fio-3.15 (previously was fio-3.20-21-g00ca8df)
 Cloning into 'quota'...
 Checking out quota 6e631074330a (previously was 13bb8c2)
 Cloning into 'xfsprogs-dev'...
 Checking out xfsprogs-dev v5.2.0 (previously was v5.6.0)
 Cloning into 'xfstests-dev'...
 Cloning into 'fsverity'...
 Cloning into 'blktests'...
 Using xfs from known stable commit point 82eda8820ddd68dab0bc35199a53a08f58b1d26c
 Running 'git reset --hard 82eda8820ddd68dab0bc35199a53a08f58b1d26c'
 HEAD is now at 82eda88 btrfs: Verify falloc on multiple holes won't leak qgroup reserved data space

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

OK I found the culprit.

It's the fsverity-utils repo here:
https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/fsverity-utils.git/

Commit:
 5cd90ca608770 ("Introduce libfsverity")

Which added the following line to the Makefile is causing this build failure:
        $(call cc-option,-Wimplicit-fallthrough) \

Po-Hsu Lin (cypressyew)
tags: added: ubuntu-zfs-xfs-generic
Po-Hsu Lin (cypressyew)
tags: added: kqa-blocker
Po-Hsu Lin (cypressyew)
summary: - ubuntu_zfs_xfs_generic failed to build on X-4.4
+ ubuntu_zfs_xfs_generic / ubuntu_xftests_* failed to build on X-4.4
tags: added: ubuntu-xfstests-btrfs ubuntu-xfstests-ext4 ubuntu-xfstests-xfs
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Patch submitted
https://<email address hidden>/T/#u

After this got applied, we can revert this temporary fix:
https://kernel.ubuntu.com/git/ubuntu/autotest-client-tests.git/commit/?id=a6abc03f78d80b74f0c740af405b3c5f41b5042c

Changed in linux (Ubuntu):
status: Incomplete → Invalid
Changed in ubuntu-kernel-tests:
status: New → In Progress
assignee: nobody → Po-Hsu Lin (cypressyew)
tags: added: sru-20200720
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Fix applied upstream:
https://<email address hidden>/

Workarouds reverted:
https://kernel.ubuntu.com/git/ubuntu/autotest-client-tests.git/commit/?id=13720efa8789e63a65b6ea9251ce70b0df500d3a

Thus I am closing this bug.

Changed in ubuntu-kernel-tests:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.