groupdel doesn't support extrausers

Bug #1840375 reported by Jamie Strandboge
16
This bug affects 6 people
Affects Status Importance Assigned to Milestone
snapd
Fix Released
Medium
Michael Vogt
shadow (Ubuntu)
Fix Released
Wishlist
Michael Vogt
Xenial
Won't Fix
Wishlist
Unassigned
Bionic
Fix Released
Wishlist
Unassigned
Disco
Won't Fix
Wishlist
Unassigned

Bug Description

snapd needs the ability to call 'groupdel --extrausers foo' to clean up after itself, but --extrausers is currently unsupported.

[Impact]
On ubuntu-core systems we want to be able to manage "extrausers" in the same
way as regular users. This requires updates to the various {user,group}{add,del} tools. Right now "groupdel" cannot handle extrausers.

This is an important feature for Ubuntu Core

[Test Case]
0. upgrade the "passwd" to the version in {xenial,bionic}-proposed
1. install the libnss-extrausers and add "extrauers" to the passwd and shadow line (see /usr/share/doc/libnss-extrausers/README for the modifications in sswitch.conf)
2. run "groupadd --extrausers foo" and verify "grep foo /var/lib/extrausers/group"
3 check /var/lib/extrausers/group for the new "foo" group
4. run "groupdel --extrausers foo"
5. check /var/lib/extrausers/group and ensure the "foo" group is removed

[Regression Potential]

 * low: this adds a new (optional) option which is off by default

CVE References

Changed in snapd:
assignee: nobody → Michael Vogt (mvo)
Revision history for this message
Michael Vogt (mvo) wrote :

I uploaded shadow_4.5-1.1ubuntu3_source.changes to eoan. We need to SRU this to xenial/bionic to have it in UC16/UC18.

Revision history for this message
Michael Vogt (mvo) wrote :

I uploaded SRUs for xenial,bionic,disco now.

description: updated
Changed in shadow (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package shadow - 1:4.5-1.1ubuntu3

---------------
shadow (1:4.5-1.1ubuntu3) eoan; urgency=medium

  * debian/patches/1014_extrausers_delgroup.patch
    - add --extrausers option to "groupdel" (LP: #1840375)

 -- Michael Vogt <email address hidden> Wed, 21 Aug 2019 11:40:17 +0200

Changed in shadow (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Jamie, or anyone else affected,

Accepted shadow into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shadow/1:4.5-1.1ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in shadow (Ubuntu Disco):
status: New → Fix Committed
tags: added: verification-needed verification-needed-disco
Changed in shadow (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Jamie, or anyone else affected,

Accepted shadow into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shadow/1:4.5-1ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in shadow (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed-xenial
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Jamie, or anyone else affected,

Accepted shadow into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shadow/1:4.2-3.1ubuntu5.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Hi,

can I interest anyone in pushing the extrausers patch as a PR to github.com/shadow-maint/shadow?

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (shadow/1:4.2-3.1ubuntu5.5)

All autopkgtests for the newly accepted shadow (1:4.2-3.1ubuntu5.5) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

nvidia-graphics-drivers-340/unknown (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#shadow

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (shadow/1:4.5-1ubuntu2.1)

All autopkgtests for the newly accepted shadow (1:4.5-1ubuntu2.1) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

buildbot/unknown (armhf)
lxc/unknown (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#shadow

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (shadow/1:4.5-1.1ubuntu2.1)

All autopkgtests for the newly accepted shadow (1:4.5-1.1ubuntu2.1) for disco have finished running.
The following regressions have been reported in tests triggered by the package:

ubiquity/unknown (armhf)
mariadb-10.3/unknown (armhf)
lxc/3.0.3-0ubuntu1 (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/disco/update_excuses.html#shadow

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Zygmunt Krynicki (zyga)
Changed in snapd:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

NOTE: I just had a look at snapd code and we still have a reference to this bug.

        // TODO: groupdel doesn't currently support --extrausers, so
        // don't try to clean up when it is specified (LP: #1840375)

I'm keeping the snapd task open

Michael Vogt (mvo)
description: updated
description: updated
Michael Vogt (mvo)
description: updated
description: updated
Revision history for this message
Sergio Cazzolato (sergio-j-cazzolato) wrote :

I ran the validation in eoan and I get segmentation fault when deleting the group. This is the log: https://paste.ubuntu.com/p/KpPZDcGc3w/
The group is deleted but the seg fault message is shown

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (shadow/1:4.2-3.1ubuntu5.5)

All autopkgtests for the newly accepted shadow (1:4.2-3.1ubuntu5.5) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

nvidia-graphics-drivers-384/unknown (armhf)
nvidia-graphics-drivers-340/unknown (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#shadow

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Steve Langasek (vorlon)
Changed in shadow (Ubuntu Disco):
status: Fix Committed → Won't Fix
Mathew Hodson (mhodson)
tags: removed: verification-needed verification-needed-disco
Changed in shadow (Ubuntu):
importance: Undecided → Wishlist
Changed in shadow (Ubuntu Xenial):
importance: Undecided → Wishlist
Changed in shadow (Ubuntu Bionic):
importance: Undecided → Wishlist
Changed in shadow (Ubuntu Disco):
importance: Undecided → Wishlist
Revision history for this message
Mathew Hodson (mhodson) wrote :
Changed in snapd:
status: Triaged → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package shadow - 1:4.5-1ubuntu2.2

---------------
shadow (1:4.5-1ubuntu2.2) bionic-security; urgency=medium

  * SECURITY UPDATE: Access to privileged information
    - debian/patches/CVE-2018-7169.patch: newgidmap:
      enforce setgroups=deny if self-mapping a group in
      src/newgidmap.c.
    - CVE-2018-7169

 -- Leonidas Da Silva Barbosa <email address hidden> Tue, 25 Jan 2022 13:26:21 -0300

Changed in shadow (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : [shadow/xenial] verification still needed

The fix for this bug has been awaiting testing feedback in the -proposed repository for xenial for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
Revision history for this message
Steve Langasek (vorlon) wrote : Proposed package removed from archive

The version of shadow in the proposed pocket of Xenial that was purported to fix this bug report has been removed because the bugs that were to be fixed by the upload were not verified in a timely (105 days) fashion.

tags: removed: verification-needed-xenial
Changed in shadow (Ubuntu Xenial):
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.