dh_installxfonts creates wrong dependency

Bug #1767792 reported by Andrew Bird
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
debhelper (Ubuntu)
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
Iain Lane

Bug Description

[ Description ]

dh_installxfonts in some cases substitutes a dependency on 'xfont-utils' into ${misc:Depends}. This package doesn't exist; the resulting .deb is uninstallable.

[ Test case ]

Rebuild 'thaixfonts' on bionic and check that the packages depend on 'xfonts-utils' and not 'xfont-utils'.

[ Regression potential ]

If the patch is still wrong, we'll still generate uninstallable packages. If it's really wrong we could break the build.

[ Original report ]

The debhelper shipped with 18.04 contains a typo that generates the wrong dependency when using dh_installxfonts in a package build. There is already a patch from the developer that introduced the typo available in Debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894835
The effect of this bug can be seen when trying to install a PPA package built in the build farm. See
https://github.com/stsp/dosemu2/issues/597#issuecomment-385178269 for a user report

summary: - dh_installxfonts creates wrong dependancy
+ dh_installxfonts creates wrong dependency
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in debhelper (Ubuntu):
status: New → Confirmed
Revision history for this message
Niels Thykier (niels-thykier) wrote : Re: [Bug 1767792] [NEW] dh_installxfonts creates wrong dependency

Andrew Bird:
> Public bug reported:
>
> The debhelper shipped with 18.04 contains a typo that generates the wrong dependency when using dh_installxfonts in a package build. There is already a patch from the developer that introduced the typo available in Debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894835
> The effect of this bug can be seen when trying to install a PPA package built in the build farm. See
> https://github.com/stsp/dosemu2/issues/597#issuecomment-385178269 for a user report
>
> ** Affects: debhelper (Ubuntu)
> Importance: Undecided
> Status: New
>
> ** Summary changed:
>
> - dh_installxfonts creates wrong dependancy
> + dh_installxfonts creates wrong dependency
>

Hi,

Upstream patch that fixes the bug:
https://salsa.debian.org/debian/debhelper/commit/98d248f46b6085d691aa29c423fa9fa2e240709a

(Should be trivial to cherry-pick).

Thanks,
~Niels

Iain Lane (laney)
description: updated
Changed in debhelper (Ubuntu):
status: Confirmed → Fix Released
Changed in debhelper (Ubuntu Bionic):
status: New → In Progress
assignee: nobody → Iain Lane (laney)
Revision history for this message
Iain Lane (laney) wrote :

uploaded to the queue, stand by for it to be reviwed, thanks!

Revision history for this message
Andy Whitcroft (apw) wrote : Please test proposed package

Hello Andrew, or anyone else affected,

Accepted debhelper into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/debhelper/11.1.6ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in debhelper (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Bambang Pranoto (bpranoto) wrote :
tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package debhelper - 11.1.6ubuntu2

---------------
debhelper (11.1.6ubuntu2) bionic; urgency=medium

  [ Iain Lane ]
  * Cherry-pick this change from Debian (98d248f4) (LP: #1767792)

  [ Nicolas Boulenguez ]
  * dh_installxfonts: Fix typo that causes a misc:Depends on
    non-existing xfont-utils. (Closes: #894835)

 -- Iain Lane <email address hidden> Thu, 10 May 2018 10:11:57 +0100

Changed in debhelper (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for debhelper has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.