Ubuntu
hplip package

setup.py crashed with TypeError in readwriteFaxInformation(): critical(QWidget, str, str, buttons: Union[QMessageBox.StandardButtons, QMessageBox.StandardButton] = QMessageBox.Ok, defaultButton: QMessageBox.StandardButton = QMessageBox.NoButton): argument 5 has unexpected type 'StandardButtons'

Bug #1745383 reported by Till Kamppeter
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
HPLIP
New
Undecided
Unassigned
hplip (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Happened while creating print/fax queues for the HP OfficeJet Pro 8730 with "hp-setup". Queues got created, seems that the crash happened afterwards. Main window did not crash, only some sub process.

ProblemType: Crash
DistroRelease: Ubuntu 18.04
Package: hplip-data 3.17.10+repack0-2
ProcVersionSignature: Ubuntu 4.13.0-25.29-generic 4.13.13
Uname: Linux 4.13.0-25-generic x86_64
ApportVersion: 2.20.8-0ubuntu6
Architecture: amd64
CurrentDesktop: GNOME
Date: Thu Jan 25 10:52:09 2018
Dependencies:
 gcc-7-base 7.2.0-18ubuntu2
 libc6 2.26-0ubuntu2.1 [origin: unknown]
 libgcc1 1:7.2.0-18ubuntu2
 liblzma5 5.2.2-1.3
 xz-utils 5.2.2-1.3
ExecutablePath: /usr/share/hplip/setup.py
InstallationDate: Installed on 2015-04-30 (1001 days ago)
InstallationMedia: Ubuntu 15.04 "Vivid Vervet" - Release amd64 (20150422)
InterpreterPath: /usr/bin/python3.6
MachineType: LENOVO 20A8X50300
PackageArchitecture: all
Papersize: letter
ProcCmdline: /usr/bin/python3 /usr/bin/hp-setup
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.13.0-25-generic root=UUID=ff9fee12-fd92-4cfd-88bf-c8f57ffba318 ro quiet splash nomdmonddf nomdmonisw vt.handoff=7
Python3Details: /usr/bin/python3.6, Python 3.6.4, python3-minimal, 3.6.3-0ubuntu2
PythonArgs: ['/usr/bin/hp-setup']
PythonDetails: /usr/bin/python2.7, Python 2.7.14+, python-minimal, 2.7.14-2ubuntu1
SourcePackage: hplip
Title: setup.py crashed with TypeError in readwriteFaxInformation(): critical(QWidget, str, str, buttons: Union[QMessageBox.StandardButtons, QMessageBox.StandardButton] = QMessageBox.Ok, defaultButton: QMessageBox.StandardButton = QMessageBox.NoButton): argument 5 has unexpected type 'StandardButtons'
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip libvirt libvirtd lpadmin lxd plugdev sambashare sudo wireshark
dmi.bios.date: 09/02/2014
dmi.bios.vendor: LENOVO
dmi.bios.version: GRET40WW (1.17 )
dmi.board.asset.tag: Not Available
dmi.board.name: 20A8X50300
dmi.board.vendor: LENOVO
dmi.board.version: SDK0E50512 STD
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: Not Available
dmi.modalias: dmi:bvnLENOVO:bvrGRET40WW(1.17):bd09/02/2014:svnLENOVO:pn20A8X50300:pvrThinkPadX1Carbon2nd:rvnLENOVO:rn20A8X50300:rvrSDK0E50512STD:cvnLENOVO:ct10:cvrNotAvailable:
dmi.product.family: ThinkPad X1 Carbon 2nd
dmi.product.name: 20A8X50300
dmi.product.version: ThinkPad X1 Carbon 2nd
dmi.sys.vendor: LENOVO

Revision history for this message
Till Kamppeter (till-kamppeter) wrote :
Apport retracing service (apport)
tags: removed: need-duplicate-check
Changed in hplip (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Badal (badalkumar) wrote :

Hi,

Support for Ubuntu 18.04 is not available in current version of HPLIP (3.17.11).
Ubuntu 18.04 suppose to be release on April 2018. Can you please mention the proper Ubuntu Version if you are using any other.

Thanks,
Badal Kumar

Changed in hplip (Ubuntu):
status: New → Opinion
Badal (badalkumar)
Changed in hplip (Ubuntu):
status: Opinion → In Progress
Revision history for this message
Tomas Korbar (tkorbar) wrote :

Hi,
This bug is caused by typo in QMessageBox constructor call. The patch im attaching fixes this bug and some other occurences of typos like this.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "hplip-qmsgbox-typos.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

Thanks for the patch.

The patch is the correct approach, but if you grep the whole source code of HPLIP for "QMessageBox" you find many more places (at least 25) with this problem.

To the HPLIP developers at HP: This is not a problem of distribution version support. It is a general bug of incorrectly using "QMessageBox".

Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

I ahve checked through the whole source code and found 40 wrong calls of QmessageBox().

I have uploaded a fixed version to Ubuntu Cosmic.

Changed in hplip (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

Here is the full patch.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hplip - 3.18.7+dfsg1-2ubuntu1

---------------
hplip (3.18.7+dfsg1-2ubuntu1) cosmic; urgency=medium

  * Made hp-toolbox starting up again (LP: #1789184).
  * Fixed all incorrect QMessageBox() calls (LP: #1745383).

 -- Till Kamppeter <email address hidden> Wed, 3 Oct 2018 15:13:00 +0200

Changed in hplip (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Cristian Alvarez (criscoso) wrote :

I'm running hplip-3.21.6 and the same error pups up.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.