Mir

[testsfail] NestedServerWithTwoDisplays.uses_passthrough_when_surface_size_is_appropriate

Bug #1709666 reported by Alan Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Alan Griffiths

Bug Description

https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4888/console

15:13:13 11: [ RUN ] NestedServerWithTwoDisplays.uses_passthrough_when_surface_size_is_appropriate ...
15:13:18 11: ==2589== Thread 6 Mir/Input Reade:
15:13:18 11: ==2589== Invalid read of size 8
15:13:18 11: ==2589== at 0x41FFA8A: std::__shared_ptr<mir_test_framework::FakeInputDeviceImpl::InputDevice, (__gnu_cxx::_Lock_policy)2>::operator->() const (shared_ptr_base.h:1055)
15:13:18 11: ==2589== by 0x41FB664: mir_test_framework::FakeInputDeviceImpl::emit_event(mir::input::synthesis::KeyParameters const&)::{lambda()#1}::operator()() const (fake_input_device_impl.cpp:68)

This looks like a race between the queue draining and deleting mtf::FakeInputDeviceImpl

Tags: testsfail

Related branches

lp:~alan-griffiths/mir/fix-1709666
Mir CI Bot: Needs Fixing (continuous-integration)
Chris Halse Rogers: Approve
Diff: 55 lines (+11/-7)
2 files modified
tests/acceptance-tests/test_nested_mir.cpp (+10/-6)
tests/mir_test_framework/server_runner.cpp (+1/-1)
lp:~ci-train-bot/mir/mir-ubuntu-artful-2983
lp:~ci-train-bot/mir/mir-ubuntu-artful-2988
lp:~ci-train-bot/mir/mir-ubuntu-xenial-2989
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Also seen here:

https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4885/consoleFull

Changed in mir:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Alan Griffiths (alan-griffiths)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

OK, in NestedMirRunner::wait_until_surface_ready() we send a pair of key-down/key-up events every 10ms until we see *any* event. We then run the test and teardown.

Other tests using FakeInputDevice ensure they have received the last event sent.

AFAICS There's nothing else to ensure the queue is drained.

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 1.0.0

Changed in mir:
status: In Progress → Fix Committed
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.