About screen - Missing image and small window.

Bug #1659426 reported by Rolando E. Rolon
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
Jabiertxof
0.92.x
Fix Released
Low
Jabiertxof

Bug Description

English:

"About Inkscape" window opens up with the smallest size possible, like ignoring all the content inside, untill it reaches the "Close" button widget and can't shrink anymore. See attachment.

Also, the screen image that should be displayed there is missing. The file at "/usr/share/inkscape/screens/about.svg" is present and is not corrupt.

Update:
- Window stops scaling down at the smallest size of the tab in the center, not the Close button.
- If the window is resized and then closed, it opens with the new size untill the program restarts. With a new session the window shrinks back again.

-- * --

Español:

La ventana de "Sobre Inkscape" se abre en el menor tamaño posible, como ignorando todo el contenido, hasta que llega al botón de cerrar y no puede encongerse más. Ver adjunto.

También falta la imagen que acompaña a la ventana. El archivo en "/usr/share/inkscape/screens/about.svg" existe y no está corrupto.

Actualización:
- La ventana deja de encogerse cuando alcanza el mínimo para la pestaña del centro, no del botón de Cerrar.
- Si la ventana se redimensiona y se cierra, esta mantiene su nuevo tamaño hasta que el programa se reinicia. Con una nueva sesión la ventana se encoge nuevamente.

-- * --

Inkscape ver. 0.92.0.r

OS: Manjaro 16.10.3 Fringilla

Kernel: x86_64 Linux 4.4.41-1-MANJARO

Revision history for this message
Rolando E. Rolon (r.r.e.designs) wrote :
description: updated
Revision history for this message
Jabiertxof (jabiertxof) wrote :

Gracias rolando por rellenar el reporte.

Thanks Rolando for fill bug.

Changed in inkscape:
assignee: nobody → Jabiertxof (jabiertxof)
Revision history for this message
Jabiertxof (jabiertxof) wrote :

Reproduced in Debian testing Inkscape 0.92.0 15324 and trunk Inkscape 0.92+devel 15450.
Proposed patch not tested yet: https://inkscape.org/en/paste/10624/

su_v (suv-lp)
tags: added: i18n translation
Revision history for this message
Jabiertxof (jabiertxof) wrote :
Revision history for this message
su_v (suv-lp) wrote :

Based on tests with archived release builds:
- not reproduced with Inkscape 0.48.5, 0.91 (es_ES.UTF-8)
- reproduced with Inkscape 0.92.0 r15299 (es_ES.UTF-8)

The reported issue affects multiple interface languages in 0.92 - the about screen is no longer available in translated versions, but the translator comment in the po file was never updated accordingly, nor was made sure that Inkscape falls back to the basic version of the about screen if no translated file is found.

Patch mentioned by Jabiertxof in comment #4 (for a fallback) tested successfully with lp:inkscape/0.92.x r15345, using es_ES.UTF-8 locale.

I would recommend that the translator comment is updated nevertheless (it seems that for now there are no plans to return to translated about screens).

--
replaces (hidden) comment 5 to clarify reference to tested patch.

Changed in inkscape:
status: New → Confirmed
Revision history for this message
su_v (suv-lp) wrote :

Please milestone for 0.92.x - affected locales in 0.92.x are be, br, es, eu, gl, id, kn, nl, pl and sl (thx @Mc). All could be fixed by adding a fallback to 'about.svg' in the source of the About dialog.

Revision history for this message
su_v (suv-lp) wrote :

Typo:
- Please milestone for 0.92.x
+ Please milestone for 0.92.1

Changed in inkscape:
status: Confirmed → In Progress
Revision history for this message
su_v (suv-lp) wrote :

The attached diff (from gist) provides fallback to 'about.svg'.

TODO: update translator comments.

Revision history for this message
su_v (suv-lp) wrote :
jazzynico (jazzynico)
Changed in inkscape:
milestone: none → 0.93
Revision history for this message
jazzynico (jazzynico) wrote :

Another possibility (if the patch is not accepted for 0.92.1) would be to update all the affected languages, and warn translators (on the list) that they should not change the original string.
I'm going to ask Bryce if it's ok to backport.

Revision history for this message
jazzynico (jazzynico) wrote :

A very simple proposal for the comment.

Revision history for this message
jazzynico (jazzynico) wrote :

We can also remove (or comment) that part of the code and consider that about screens no longer need to be translated.

Revision history for this message
su_v (suv-lp) wrote :

Proposal to update the comment (comment 12) looks good to me.

Revision history for this message
jazzynico (jazzynico) wrote :

Comment fixed in lp:inkscape rev. 15456.

Revision history for this message
jazzynico (jazzynico) wrote :
Revision history for this message
su_v (suv-lp) wrote :

Cumulative patch tested successfully with lp:inkscape/0.92.x r15345 (on OS X), with some of the affected locales (be, es, eu, kn), both via LC_ALL (on the command line), and the interface language selection in Inkscape's preferences:

The patched build displays the About screen as expected, whereas with the unpatched build it is missing (in all tested locales).

Revision history for this message
Bryce Harrington (bryce) wrote :

Ack'd for landing on 0.92.x stable branch.

jazzynico (jazzynico)
Changed in inkscape:
status: In Progress → Fix Committed
Revision history for this message
jazzynico (jazzynico) wrote :

Fixed in lp:inkscape/0.92.x rev. 15346.

Changed in inkscape:
importance: Undecided → Low
Revision history for this message
Jabiertxof (jabiertxof) wrote :

Thanks!

Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.