Inkscape

0.92 Stored default line height auto-change unit to document unit

Bug #1645016 reported by Jabiertxof
34
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
Tavmjong Bah
Inkscape 1.0
0.92.x
Fix Released
Medium
Tavmjong Bah
Inkscape 0.92.1 "0.92.1"

Bug Description

Steps to reproduce:
1.Set default line height to 1 unitless
2.Close inkscape
3.Open inkscape
4.Default line height is 1mm and you need to change line height (2 or 3 click to set again 1unitless) every time you open inkscape

Inkscape convert the default unit to the doc unit. with units change pt to mm and so on. this is bad but with unitless is totaly broken.

I feel god if can mark it as blocker for 0.92, because users usualy are more confortable with unitless line height

Revision history for this message
su_v (suv-lp) wrote :

@JazzyNico - could you please set milestone to 0.92 (for now)?
@Jabiertxof - if this needs to be considered as release blocker, it might be best to bring it up on the mailing list or to notify the release manager directly (on irc).

tags: added: preferences
Revision history for this message
su_v (suv-lp) wrote :

Reproduced with Inkscape 0.92.0 r15299 and lp:inkscape/0.92.x r15314 on OS X 10.7.5.

Changed in inkscape:
status: New → Confirmed
summary: - 0.92 Stored default line height auto chage unit to document unit
+ 0.92 Stored default line height auto-change unit to document unit
Revision history for this message
su_v (suv-lp) wrote :

@JazzyNico - could you please milestone to 0.92.1?

It would be great if this could be further investigated, ideally in time for the bug fix release: besides auto-switching from unit-less or relative unit (%, em, ex) to absolute units (displayed in document units, stored in SVG user units aka 'px'), the conversion also seems off by factor 1/2.

jazzynico (jazzynico)
Changed in inkscape:
importance: Undecided → Medium
milestone: none → 0.92.1
status: Confirmed → Triaged
Revision history for this message
su_v (suv-lp) wrote :

Fixed by Tavmjong Bah in revision 15462:
 Prevent display units from effecting 'line-height' unit.
 Allow relative units to be saved in preferences for 'line-height'.
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/15462

Changed in inkscape:
status: Triaged → Fix Committed
tags: added: backport-proposed
Revision history for this message
su_v (suv-lp) wrote :

@jazzynico - could you pump milestone to 0.93 please, and add a bug task for 0.92.x?

Revision history for this message
su_v (suv-lp) wrote :

Fix in rev 15462 tested successfully with lp:inkscape r15463 on Ubuntu 14.04.5 LTS:
Relative units for line-height (%, em, ex) are saved to and restored from the preferences as expected (independent of the document units of the default template or the current document).

jazzynico (jazzynico)
Changed in inkscape:
assignee: nobody → Tavmjong Bah (tavmjong-free)
milestone: 0.92.1 → 0.93
Revision history for this message
Hachmann (marenhachmann) wrote :

Isn't this 'fix committed' for 0.92.1?

From the commit message, it sounds to me as if it has been backported in
http://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/revision/15362
(would also need to be updated in release notes)

Revision history for this message
su_v (suv-lp) wrote :

Fix backported in
https://bazaar.launchpad.net/~inkscape.dev/inkscape/0.92.x/revision/15362

su_v (suv-lp)
tags: removed: backport-proposed
Revision history for this message
Hachmann (marenhachmann) wrote :

Thx!

Qantas94Heavy (qantas94heavy)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.