Launchpad itself

can't browse to revisions whose revid contains %2F in loggerhead/codebrowse

Bug #158584 reported by Michael Hudson-Doyle
8
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Michael Hudson-Doyle
loggerhead
Fix Released
Undecided
Unassigned
1.6
Fix Released
Undecided
Unassigned

Bug Description

As mentioned in bug 88286:

"""
Argh argh argh, it seems the problem with the pydoctor branches is in fact a problem with cherrypy. It "helpfully" mangles url segments that contain %2Fs:

        # Decode any leftover %2F in the virtual_path atoms.
        virtual_path = [x.replace("%2F", "/") for x in virtual_path]

So, I don't know how to fix this without getting away from cherrypy (2). Maybe make the considered revid a query argument? That's such a hack though.
"""

I still don't really know how to fix it. Maybe I can simply whack in a different HTTP frontend...

Related branches

lp:~mwhudson/loggerhead/wsgi-ify (Merged)
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Isn't this just a cherrypy bug?

Revision history for this message
Martin Pool (mbp) wrote :

If we're generating the urls can we not just pre-escape the urls ourselves?

Changed in launchpad-bazaar:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Jelmer: yes, but it still a problem that we need to deal with.

Martin: I couldn't think of a way that would work, but maybe I was being thick.

Revision history for this message
Jonathan Lange (jml) wrote :

I would like to have a look at loggerhead. Perhaps fixing this bug can be a good way in.

Changed in launchpad-bazaar:
assignee: nobody → jml
milestone: none → 1.2.3
Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 158584] Re: can't browse to revisions whose revid contains %2F in loggerhead/codebrowse

Am Freitag, den 07.03.2008, 15:34 +0000 schrieb Jonathan Lange:
> I would like to have a look at loggerhead. Perhaps fixing this bug can
> be a good way in.
 I think the latest loggerhead release claims to have fixed this.

Cheers,

Jelmer
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 158584] Re: can't browse to revisions whose revid contains %2F in loggerhead/codebrowse

Am Freitag, den 07.03.2008, 16:04 +0000 schrieb Jelmer Vernooij:
> Am Freitag, den 07.03.2008, 15:34 +0000 schrieb Jonathan Lange:
> > I would like to have a look at loggerhead. Perhaps fixing this bug can
> > be a good way in.
> I think the latest loggerhead release claims to have fixed this.
 Bug 88286

Cheers,

Jelmer
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

No, that was about _all other_ characters that need url-encoding. This one is just about "%2F", and it's a cherrypy stupidity.

Revision history for this message
Jonathan Lange (jml) wrote :

This was optimistic.

Changed in launchpad-bazaar:
milestone: 1.2.3 → none
Revision history for this message
Martin Albisetti (beuno) wrote :

paste should solve *all* our problems :)

Changed in loggerhead:
status: New → In Progress
Martin Albisetti (beuno)
Changed in loggerhead:
status: In Progress → Fix Committed
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Yay we have the fix on bazaar.launchpad.net now!

Changed in launchpad-bazaar:
status: Confirmed → Fix Released
assignee: jml → mwhudson
Martin Albisetti (beuno)
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.