OOPS using +adminteammerge

Getting an OOPS trying to merge https://launchpad.net/~ubuntume-googlegroups with https://launchpad.net/~ubuntume.team.

You get this even if you type in the name of a non-existent person in the dupe_person input box, btw.

Tom, the problem here is that you're trying to merge a inactive person into a team. That should not be possible. Clearly the form should tell you that instead of OOPSing.

Increasing the importance.

kiko said "it happens when the person in the dupe textbox doesn't exist. that page lacks a validator"

Tom just triggered OOPS-1069EC156 while trying to duplicate a private team into ~registry.

The workaround was to make the team public and then merge.

Joey may have misparaphrased me or I may have screwed it up but the reality is that this is a generic error that happens for any situation where the team can't be merged -- maybe the bug here is that there is no error message to tell us why the merge failed.

We see this error because the vocabulary used on +adminteammerge only includes valid teams, but the validate() method of AdminTeamMergeView ignores that fact and assumes data['dupe_person'] will always exist (not true when the dupe team is not considered valid; either unclaimed, private or already merged).

If we just changed the validate() method to do nothing when 'dupe_person' is not in data, we'd get a (probably meaningless) error message rather than an OOPS.

The correct fix, though, would be to write a new vocabulary including private and unclaimed teams, to be used on this page.

r8787

Fixed released in Launchpad sinzui.

Still not fixed; or bug 372519 isn't a duplicate.

https://answers.edge.launchpad.net/launchpad/+question/74409 is the request.
~debian-ocaml-maint appears to be a person record (vs a team)
wants to be merged into ~ocaml-maint which is a team.

No longers OOPS', but "There is 1 error. Constraint not satisfied." isn't an obvious message as to what the problem is.
Tho the drop down box does help a little and is a nice touch.