Remove the "Military settings" option
Bug #1339861 reported by
wl-zocker
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
When you click on an empty field in r7063, a new options (besides building a building or a flag) is available: Military settings. When you click on the tab, the window is empty (see attached screenshot). The whole tab should be removed.
This might be related to the fix in r7025 where the retreat option was removed. I assume the option I see is a kind of relict from that feature.
Related branches
lp:~widelands-dev/widelands/bug-1339861
- SirVer: Approve
-
Diff: 260 lines (+0/-202)4 files modifiedsrc/wui/CMakeLists.txt (+0/-2)
src/wui/fieldaction.cc (+0/-16)
src/wui/military_box.cc (+0/-105)
src/wui/military_box.h (+0/-79)
Revision history for this message
| wl-zocker (wl-zocker) wrote | #1 |
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #2 |
| Changed in widelands: | |
| importance: | Undecided → Low |
| milestone: | none → build19-rc1 |
| status: | New → Triaged |
| tags: | added: lowhangingfruit |
| Changed in widelands: | |
| assignee: | nobody → GunChleoc (gunchleoc) |
| status: | Triaged → In Progress |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| Changed in widelands: | |
| assignee: | GunChleoc (gunchleoc) → nobody |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #3 |
To post a comment you must log in.
You're probably right.
The retreat option was hidden via a boolean flag in the code. My theory is that this flag was removed along with retreat, but it was also used to check whether this tab should be shown.