sql_common.h:24:10: fatal error: 'hash.h' file not found

Bug #1316001 reported by Denis Denisov
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MySQL Data Dumper
Won't Fix
Undecided
Unassigned

Bug Description

Attach patch fixed include/private headers

include/mysql/sql_common.h:24:10: fatal error: 'hash.h' file not found
#include <hash.h>
         ^

Related branches

Revision history for this message
Denis Denisov (denji0k-deactivatedaccount) wrote :

C{C}FLAGS has -I followed path to include/mysql/private

information type: Public → Private
Revision history for this message
Denis Denisov (denji0k-deactivatedaccount) wrote :

Attach file

information type: Private → Public
Revision history for this message
Denis Denisov (denji0k-deactivatedaccount) wrote :
Revision history for this message
Michael Widenius (monty) wrote :

The real problem here is that no application should ever include sql_common.h or try to execute, the internal to libmysql functions, simple_command() or advanced_command() directly.

The primary reason for this is that these functions are not safe for internal API or structure changes and may cause applications crashes between even minor versions of libmysql.a

The right way to solve this, if mysql data dumper really need this, would be to create two new api functions,
mysql_simple_command() and mysql_advanced_command() and add these to libmysql.a

Before doing the above, I would like to know why mysql data dumper is calling simple_command() directly instead of calling the corresponding command (like mysql_list_fields).

Regards,
Monty

Revision history for this message
Denis Denisov (denji0k-deactivatedaccount) wrote :
Revision history for this message
Domas Mituzas (domas-mituzas) wrote :

Monty,

I guess this API is not exposed in MySQL client:

binlog.c: if (simple_command(conn, COM_BINLOG_DUMP, (const char *)buf,
binlog.c: if (simple_command(conn, COM_BINLOG_DUMP, buf,

Revision history for this message
Max Bubenick (max-bubenick) wrote :

For now we will disable the to code that needs simple_command, so binlog code will be disabled by default until we can fix this.

Changed in mydumper:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.