Wrong sound played

Bug #1304638 reported by Nasenbaer
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Teppo Mäenpää

Bug Description

Since the additional chat sounds for the lobby were introduced, I noticed some strange wrong sounds played.

* Once an ingame message is received (e.g. "water found" or "out of granite") it seems like a random sound is played - sometimes the correct message_00, sometimes message_chat_00 and sometimes message_freshmen_00 (If a military message arrived, it seemed to me as if the military message sounds were played correctly, but maybe I just had luck on that ones)
* If I open the chat window, but there is no new chat message still the message_chat_00 is played.

Tags: sounds

Related branches

Revision history for this message
SirVer (sirver) wrote :

It could be that these are two issues: The first sounds like for the set of sounds that are played more than one sound was loaded. This could be due to wrong globbing in SoundHandle::load_fx_if_needed - I would start with some printf debugging there.

The second issue must be unrelated to this.

Revision history for this message
Teppo Mäenpää (kxq) wrote :

I guess that message_chat_00 and sometimes message_freshmen_00 should not start with the message_ -prefix.

Teppo Mäenpää (kxq)
Changed in widelands:
assignee: nobody → Teppo Mäenpää (kxq)
Revision history for this message
Teppo Mäenpää (kxq) wrote :

The attached branch fixes the first part.

Revision history for this message
Teppo Mäenpää (kxq) wrote :

Revision 6937 fixes the 2nd part, too.

Revision history for this message
Teppo Mäenpää (kxq) wrote :

intended to say: revision 6937 of the related firstfix branch.

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

The attached branch has been merged, so I assume this has been fixed.

Please see follow-up bug 1308473, though.

Changed in widelands:
importance: Undecided → Medium
status: Confirmed → Fix Committed
GunChleoc (gunchleoc)
tags: added: sounds
removed: sound
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.