Inkscape

Inkscape 0.48.4 fails to compile with boehm-gc 7.4.0+

Bug #1265072 reported by Vladimir Smirnov
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
High
Vladimir Smirnov
Inkscape 0.48.5

Bug Description

boehm-gc 7.4 introduced some API changes, for example GC_version is no longer exported, instead of it, there is function GC_get_version. Also some functions's prototypes have changed (for example GC_general_register_disappearing_link is now (void **, const void *), not (void **, void *).

First part seems to be fixed in current trunk, 2nd part is not.

I'm attaching suggested patch for this situation.

Tags: build
Revision history for this message
Vladimir Smirnov (civilian) wrote :
su_v (suv-lp)
tags: added: build
Revision history for this message
su_v (suv-lp) wrote :

Confirmed with just updated boehmgc port on OS X 10.7.5.

Changed in inkscape:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
su_v (suv-lp) wrote :

Patch tested ok (build succeeds) with lp:inkscape/0.48.x (r10006) and current trunk (r12885) on OS X 10.7.5, using
- boehmgc 7.2c, 7.2d
- boehmgc 7.4.0

Changed in inkscape:
status: Confirmed → Triaged
milestone: none → 0.91
tags: added: backport-proposed
Revision history for this message
David Evans (devans-n) wrote :

Patch committed to MacPorts and build succeeds with lp:inkscape/0.48.x (r10006) (MacPorts port inkscape) and current trunk (r12885) (MacPorts port inkscape-devel) using boehmgc 7.4.0 on all 4 MacPorts buildbots.
OS X 10.6 (Snow Leopard) thru OS X 10.9 (Mavericks).

Revision history for this message
suresh (suresh-meetsme) wrote :

Yeah works perfectly fine. Thanks for the patch.

Revision history for this message
su_v (suv-lp) wrote :

@JazzyNico - could you test the patch on Windows with current devlibs for any negative side-effects?

Revision history for this message
jazzynico (jazzynico) wrote :

Patch tested successfully on Windows XP, Inkscape trunk revision 12866 and 0.48.x branch revision 10006, with gc-7.1 (devlibs r49).

Changed in inkscape:
assignee: nobody → Vladimir Smirnov (civilian)
status: Triaged → In Progress
Revision history for this message
su_v (suv-lp) wrote :

Slightly modified fix committed by Johan Engelen in r12918.

@Vladimir - thanks a lot for the patch!

Changed in inkscape:
status: In Progress → Fix Committed
Revision history for this message
su_v (suv-lp) wrote :

Fix backported to stable release branch lp:inkscape/0.48.x in r10007.

Changed in inkscape:
milestone: 0.91 → 0.48.5
Alex Valavanis (valavanisalex)
tags: removed: backport-proposed
Alex Valavanis (valavanisalex)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.