upstart-local-bridge clobbers $PATH with its events
Bug #1235480 reported by
Steve Langasek
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
upstart |
Fix Committed
|
Undecided
|
James Hunt | ||
upstart (Ubuntu) |
Fix Released
|
High
|
Steve Langasek | ||
Saucy |
Fix Released
|
High
|
Steve Langasek |
Bug Description
The dbus bridge was recently fixed to not clobber $PATH in its events, but it turns out the same bug affects the local bridge.
var = NIH_MUST (nih_sprintf (NULL, "PATH=%s", socket_path));
NIH_MUST (nih_str_array_addp (&env, NULL, NULL, var));
This should be fixed to be called e.g. SOCKET_PATH instead. Or maybe just dropped? I'm not sure there's really a need to include this info in the event.
Related branches
lp:~vorlon/upstart/lp.1235480
Merged
into
lp:upstart
- Stéphane Graber (community): Approve
-
Diff: 56 lines (+9/-4)3 files modifiedChangeLog (+5/-0)
extra/man/upstart-local-bridge.8 (+3/-3)
extra/upstart-local-bridge.c (+1/-1)
Changed in upstart: | |
status: | New → Fix Committed |
To post a comment you must log in.
This obviously makes the file bridge unusable for any real purposes until it's fixed.