Mir

Mir does not support eglSwapInterval(0)

Bug #1130553 reported by Daniel van Vugt
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Mir development team
Mir 0.0.6

Bug Description

Mir (Mesa) does not support eglSwapInterval(0)

This is important for benchmarking, or else all results will be bound to 60 FPS.

Related branches

lp:~raof/mir/gbm-cleanup-extra
PS Jenkins bot (community): Approve (continuous-integration)
Robert Ancell: Approve
Diff: 1186 lines (+635/-227)
24 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+6/-0)
debian/control (+2/-2)
include/shared/mir_toolkit/mesa/native_display.h (+14/-18)
src/client/CMakeLists.txt (+2/-1)
src/client/gbm/gbm_client_platform.cpp (+25/-3)
src/client/gbm/gbm_native_surface.cpp (+78/-0)
src/client/gbm/gbm_native_surface.h (+42/-0)
src/client/gbm/mesa_native_display_container.cpp (+4/-39)
src/server/graphics/gbm/CMakeLists.txt (+1/-0)
src/server/graphics/gbm/internal_client.cpp (+6/-1)
src/server/graphics/gbm/internal_client.h (+2/-0)
src/server/graphics/gbm/internal_native_display.cpp (+4/-36)
src/server/graphics/gbm/internal_native_display.h (+2/-10)
src/server/graphics/gbm/internal_native_surface.cpp (+77/-0)
src/server/graphics/gbm/internal_native_surface.h (+62/-0)
tests/unit-tests/client/gbm/CMakeLists.txt (+1/-0)
tests/unit-tests/client/gbm/test_gbm_client_platform.cpp (+0/-11)
tests/unit-tests/client/gbm/test_native_surface.cpp (+114/-0)
tests/unit-tests/graphics/android/test_internal_client_interpreter.cpp (+6/-0)
tests/unit-tests/graphics/gbm/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/gbm/test_internal_client.cpp (+15/-5)
tests/unit-tests/graphics/gbm/test_internal_native_display.cpp (+0/-100)
tests/unit-tests/graphics/gbm/test_internal_native_surface.cpp (+170/-0)
lp:~kdub/mir/gbm-cleanup
Rejected for merging into lp:~mir-team/mir/trunk
Alexandros Frantzis (community): Approve
Alan Griffiths: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 1141 lines (+631/-223)
22 files modified
debian/changelog (+6/-0)
include/shared/mir_toolkit/mesa/native_display.h (+14/-18)
src/client/CMakeLists.txt (+1/-0)
src/client/gbm/gbm_client_platform.cpp (+25/-3)
src/client/gbm/gbm_native_surface.cpp (+78/-0)
src/client/gbm/gbm_native_surface.h (+42/-0)
src/client/gbm/mesa_native_display_container.cpp (+4/-39)
src/server/graphics/gbm/CMakeLists.txt (+1/-0)
src/server/graphics/gbm/internal_client.cpp (+6/-1)
src/server/graphics/gbm/internal_client.h (+2/-0)
src/server/graphics/gbm/internal_native_display.cpp (+4/-36)
src/server/graphics/gbm/internal_native_display.h (+2/-10)
src/server/graphics/gbm/internal_native_surface.cpp (+77/-0)
src/server/graphics/gbm/internal_native_surface.h (+62/-0)
tests/unit-tests/client/gbm/CMakeLists.txt (+1/-0)
tests/unit-tests/client/gbm/test_gbm_client_platform.cpp (+0/-11)
tests/unit-tests/client/gbm/test_native_surface.cpp (+114/-0)
tests/unit-tests/graphics/android/test_internal_client_interpreter.cpp (+6/-0)
tests/unit-tests/graphics/gbm/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/gbm/test_internal_client.cpp (+15/-5)
tests/unit-tests/graphics/gbm/test_internal_native_display.cpp (+0/-100)
tests/unit-tests/graphics/gbm/test_internal_native_surface.cpp (+170/-0)
lp:~kdub/mir/interval0-signal
PS Jenkins bot (community): Approve (continuous-integration)
Daniel van Vugt: Approve
Alexandros Frantzis (community): Approve
Diff: 786 lines (+418/-23)
24 files modified
include/client/mir_toolkit/mir_client_library.h (+21/-0)
include/server/mir/compositor/buffer_allocation_strategy.h (+1/-1)
include/server/mir/compositor/buffer_stream_surfaces.h (+1/-0)
include/server/mir/compositor/swapper_factory.h (+6/-2)
include/server/mir/shell/surface.h (+1/-0)
include/server/mir/surfaces/buffer_stream.h (+1/-0)
include/server/mir/surfaces/surface.h (+2/-0)
include/shared/mir_toolkit/common.h (+1/-1)
include/test/mir_test_doubles/mock_buffer_stream.h (+2/-0)
include/test/mir_test_doubles/mock_swapper_factory.h (+2/-2)
include/test/mir_test_doubles/stub_buffer_stream.h (+4/-0)
src/client/mir_client_library.cpp (+12/-0)
src/client/mir_surface.cpp (+2/-0)
src/server/compositor/buffer_stream_surfaces.cpp (+4/-0)
src/server/compositor/swapper_factory.cpp (+36/-9)
src/server/compositor/switching_bundle.cpp (+2/-2)
src/server/shell/surface.cpp (+14/-1)
src/server/surfaces/surface.cpp (+5/-0)
tests/integration-tests/CMakeLists.txt (+1/-0)
tests/integration-tests/test_swapinterval.cpp (+226/-0)
tests/unit-tests/compositor/test_buffer_stream.cpp (+9/-0)
tests/unit-tests/compositor/test_swapper_factory.cpp (+50/-2)
tests/unit-tests/compositor/test_switching_bundle.cpp (+3/-3)
tests/unit-tests/surfaces/test_surface.cpp (+12/-0)
Daniel van Vugt (vanvugt)
information type: Proprietary → Public
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yep, looks like we will need to solve this. If only to get useful benchmarks...

$ glmark2-es2-mir
libEGL warning: unsupported platform (null)
=======================================================
    glmark2 2012.12
=======================================================
    OpenGL Information
    GL_VENDOR: Intel Open Source Technology Center
    GL_RENDERER: Mesa DRI Intel(R) Sandybridge Mobile
    GL_VERSION: OpenGL ES 3.0 Mesa 9.2.0
=======================================================
[build] use-vbo=false: FPS: 60 FrameTime: 16.667 ms
[build] use-vbo=true: FPS: 60 FrameTime: 16.667 ms
[texture] texture-filter=nearest: FPS: 60 FrameTime: 16.667 ms
[texture] texture-filter=linear: FPS: 60 FrameTime: 16.667 ms
[texture] texture-filter=mipmap: FPS: 60 FrameTime: 16.667 ms
[shading] shading=gouraud: FPS: 60 FrameTime: 16.667 ms
[shading] shading=blinn-phong-inf: FPS: 60 FrameTime: 16.667 ms
[shading] shading=phong: FPS: 60 FrameTime: 16.667 ms
[bump] bump-render=high-poly: FPS: 60 FrameTime: 16.667 ms
[bump] bump-render=normals: FPS: 60 FrameTime: 16.667 ms
[bump] bump-render=height: FPS: 60 FrameTime: 16.667 ms
......

Robert Ancell (robert-ancell)
Changed in mir:
status: New → Triaged
Daniel van Vugt (vanvugt)
Changed in mir:
assignee: nobody → Mir development team (mir-team)
status: Triaged → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.0.4

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.0.4
Revision history for this message
Darxus (darxus) wrote :

Looks like this is the relevant commit: http://bazaar.launchpad.net/~mir-team/mir/trunk/revision/749

Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision 780, scheduled for release in mir, milestone 0.0.4

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The latest commit says it's not quite done yet:

revno: 780 [merge]
author: Kevin DuBois <email address hidden>
committer: Tarmac
branch nick: trunk
timestamp: Wed 2013-06-26 15:57:42 +0000
message:
  Activate sending a "swapinterval" signal over IPC. Add client api for software clients to request different swapintervals. (eglSwapInterval is not glued together just yet)
  Currently only swapinterval of 0 or 1 is supported. Fixes: https://bugs.launchpad.net/bugs/1130553.

  Approved by PS Jenkins bot, Daniel van Vugt, Alexandros Frantzis.

Changed in mir:
status: Fix Committed → In Progress
milestone: 0.0.4 → none
Robert Ancell (robert-ancell)
Changed in mir:
milestone: none → 0.0.5
Robert Ancell (robert-ancell)
Changed in mir:
milestone: 0.0.5 → 0.0.6
Robert Ancell (robert-ancell)
Changed in mir:
milestone: 0.0.6 → 0.0.7
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This appears to be fully functional now.

Changed in mir:
milestone: 0.0.7 → none
status: In Progress → Fix Released
Robert Ancell (robert-ancell)
Changed in mir:
milestone: none → 0.0.6
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.