Initial startup can take a long time (+20s) due to the "Downloads" find routine.

Image Writer searches almost any subdirectory of my home directory for the Downloads folder. Sure, this may take some time.
The search should be restricted to only immediate subdirectories by replacting QDirIterator::Subdirectories with QDirIterator::NoIteratorFlags.

Even better would be using the SHGetKnownFolderPath API call:

PWSTR pPath = NULL;
if (SUCCEEDED( SHGetKnownFolderPath( FOLDERID_Downloads, KF_FLAG_NO_ALIAS, 0, &pPath)) )
{
    myHomeDir = QString::fromWCharArray( pPath );
    CoTaskMemFree( pPath );
}

On Fri, 2013-02-15 at 02:06 +0000, Roland Rüdenauer wrote:
> Image Writer searches almost any subdirectory of my home directory for the Downloads folder. Sure, this may take some time.
> The search should be restricted to only immediate subdirectories by replacting QDirIterator::Subdirectories with QDirIterator::NoIteratorFlags.
Not sure if this will work on XP or future versions of Windows.
XP: c:\Documents and Settings\<user>\My Documents\Downloads <-- two
layers deep here.
Win7: c:\users\<userid>\Downloads <--Works here.
Win8: Same.

I don't have a copy of vista off hand.
From http://msdn.microsoft.com/en-us/library/windows/desktop/bb762188%
28v=vs.85%29.aspx
Minimum supported client
 Windows Vista

So again, won't support XP.

I will revisit this probably mid summer. Right now, XP still holds ~20%
of the install base (according to some of my statistic searches).

I could hard code it, but I hate hard coded paths in compiled code. I
have other solutions I will be looking into though, and I hope to
address this in the next month.

--
--

Tobin Davis

A formal parsing algorithm should not always be used.
  -- D. Gries

We can do some shortcutting by using QSysInfo (http://doc.qt.digia.com/4.6/qsysinfo.html#WinVersion-enum) and then looking for a directory that *should* exist, following it up with a search if the expected dir wasn't found.

That way, we have a fallback, but don't go on some convoluted search if it isn't necessary....

Even if we don't use QSysInfo, we can have a list of "known locations" that we search for first, again falling back to a more extensive search if nothing is found.