UEFI signing failures cause binaries to be republished continuously
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Colin Watson |
Bug Description
A UEFI signing failure (or possibly any CustomUploadError) during process-accepted causes the PackageUpload to remain ACCEPTED, even though BPPHs have already been created (and will be committed, as process-accepted deliberately commits even upon failure). The next run of process-accepted does the same thing, and the next, and the next, causing unbounded republication of the upload's binaries.
ppa:apw/signing has more than 120000 excess publications, and ppa:jacob/ppa has somewhere north of 343000 of them. There are more than likely other less bad cases.
We might just want to skip signing if there's no key, but that won't fix the ppa:apw/signing case, which is failing with this error:
warning: file-aligned section .text extends beyond end of file
warning: checksum areas are greater than image size. Invalid section table?
Related branches
- Curtis Hovey (community): Approve (code)
-
Diff: 299 lines (+59/-62)7 files modifiedlib/lp/archivepublisher/customupload.py (+2/-1)
lib/lp/archivepublisher/ddtp_tarball.py (+2/-2)
lib/lp/archivepublisher/debian_installer.py (+2/-2)
lib/lp/archivepublisher/dist_upgrader.py (+2/-2)
lib/lp/archivepublisher/tests/test_uefi.py (+15/-12)
lib/lp/archivepublisher/uefi.py (+30/-37)
lib/lp/soyuz/model/queue.py (+6/-6)
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → William Grant (wgrant) |
status: | In Progress → Triaged |
assignee: | William Grant (wgrant) → nobody |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Colin Watson (cjwatson) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Fixed in stable r16251 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 16251>.