Cleaned up the CORE scripts

Asked by LeoKomarov

I cleaned up the script, fixed some spelling mistakes, changed "sleep" timing, added a check to ask if the user wanted to update the package lists, as this was the longest operation, even if the lists didn't need to be updated and removed the "Do you want to continue?" check.
Its now 1 script, so there's no need to have the auto installer anymore. After quite a bit of work with sed, I got it to install on the first run of the script. It only copies the files needed over. It doesn't try to install after.
The deb is made up of my version, without the installer of course.
http://db.tt/oPFGxE - tar.gz
http://db.tt/cQfkld - deb

Question information

Language:
English Edit question
Status:
Solved
For:
uCareSystem Edit question
Assignee:
No assignee Edit question
Solved by:
LeoKomarov
Solved:
Last query:
Last reply:
Revision history for this message
Salih EMIN (salih-emin) said :
#1

Awesome work Nathan ! I will test your mod's and I am sure they will make to the next release.

Revision history for this message
Salih EMIN (salih-emin) said :
#2

Nathan, I've managed to find some spare time to check your code in your "proposed" brunch. I've some questions/suggestions before final merge:

1) As you can check in my final revision I removed the (stupid) question that asks "Do you want to continue". This is because if the user adds 2cuCORE in a CRONTAB, it will not function as it meant to be, while its waiting an answer. So I've changed it to "... will start in 5 seconds" so the user can read the welcome notes and if he use it in cron, it will function correctly.

2) Also, there should always be an updated apt-list before starting to download the upgraded packages. There is always a chance that a package has been pushed in repos 5 minutes ago. This happened recently with ground-control*.deb it was in 1.6.1 one hour ago and was updated 5 minutes ago !

3)The "one time install" is a good idea. But if you check the auto installer it also installs the dependencies : deborphan, axel
So if this could come in to the "one time install" then I think we are ready to merge.... ;)

Revision history for this message
LeoKomarov (leokomarov) said :
#3

Just updated it with your suggestions. It should install the dependencies if either of the two files aren't found.
Should be ready for merging, but you might need to take out a few things. Remember to change the version number.

Revision history for this message
Salih EMIN (salih-emin) said :
#4

Thnx Nathan! great work. I will test the code once I am able to have some time (Upgrading to Ubuntu 10.04 comes first :P)