lp:~wiml/libdrizzle/integer-sizes
- Get this branch:
- bzr branch lp:~wiml/libdrizzle/integer-sizes
Branch merges
- Andrew Hutchings: Approve
-
Diff: 618 lines (+134/-80)14 files modifiedlibdrizzle-5.1/constants.h (+15/-21)
libdrizzle-5.1/field_client.h (+17/-2)
libdrizzle/binlog.cc (+5/-5)
libdrizzle/conn.cc (+6/-0)
libdrizzle/field.cc (+36/-18)
libdrizzle/handshake.cc (+2/-2)
libdrizzle/pack.cc (+19/-7)
libdrizzle/pack.h (+2/-1)
libdrizzle/result.cc (+10/-8)
libdrizzle/result.h (+6/-6)
libdrizzle/statement.cc (+1/-1)
libdrizzle/statement_param.cc (+8/-2)
libdrizzle/structs.h (+6/-6)
tests/unit/statement.c (+1/-1)
Related bugs
Bug #1148425: integer values do not unpack correctly in prepared stmt | High | Fix Released | |
Bug #1150811: drizzle_state_field_read() can read past packet boundary | Medium | Fix Released |
Related blueprints
Branch information
Recent revisions
- 120. By Wim Lewis
-
The protocol allows fields as large as 2^64 bytes, so use a uint64_t to store field sizes and offsets within fields. Added some documentation for drizzle_
field_read( ) and drizzle_ field_buffer( ). - 119. By Wim Lewis
-
It's possible to have more than 1024 (256*8) columns, so null_bitmap_length has to be larger than a uint8_t.
- 118. By Wim Lewis
-
The amount of data in param->data can technically be more than 2^32; it's limited by the size of our memory, so param->length should be a size_t.
- 117. By Wim Lewis
-
Avoid an unnecessary type cast to size_t.
Avoid a use-after-free of row_list if we have a realloc failure while reading a large result set. - 114. By Wim Lewis
-
Fix fragmentary-
field-reading logic in drizzle_ state_field_ read()
so that it doesn't accidentally cross a packet boundary.
Adjusted types of some field variables to match the largest values that
can be stored in them.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:libdrizzle